Simplify and fix the NFS configuration

[rmccue]

PR on #406.

• Fixes the mount options to actually be used.
• Refactors to remove duplication.
• Automatically uses vagrant-bindfs per VMware permissions fix #307 if available.
• Adds documentation for the NFS setting.

Tested on:

• VirtualBox with default
• VirtualBox with default + vagrant-bindfs
• VirtualBox with nfs
• VirtualBox with nfs + vagrant-bindfs
• VMware with default
• VMware with default + vagrant-bindfs
• VMware with nfs
• VMware with nfs + vagrant-bindfs

To test: vary nfs option in YAML, and try with the bindfs plugin installed (vagrant plugin install vagrant-bindfs vagrant plugin uninstall vagrant-bindfs).

[rmccue]

@BronsonQuick Can you a) review/merge, and b) test on VMware? Should only take a few minutes to test (only need to toggle options and vagrant reload, no need to destroy & up).

[BronsonQuick]

@rmccue I just did a quick run with VMWare with default and it's got the same issue it had before which is:

The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

mount | grep " /mnt/vagrant-mounts/1000-1000 "
if test $? -ne 0; then
mkdir -p '/mnt/vagrant-mounts/1000-1000'
chmod 700 '/mnt/vagrant-mounts'
vmhgfs-fuse -o allow_other,default_permissions,uid=1000,gid=1000,dmode=777,fmode=777 .host:/ '/mnt/vagrant-mounts/1000-1000'
fi
Stdout from the command:

Stderr from the command:

fuse: unknown option `dmode=777'

My other branch that you closed fixed that issue using NFS for VMWare.

I'll try and test the other variations tonight for you.

[BronsonQuick]

VMware with default + vagrant-bindfs doesn't work

[BronsonQuick]

Alrighty so after some quick testing while I was updating some other software these two aren't working:

• VMware with default
• VMware with default + vagrant-bindfs

I thinking maybe it'd be easier to throw a notice if VMWare is being used and get them to switch nfs on or we automagically flip that.

I had a bit of a Google last night and I could detect --provider=vmware_fusion with ARGV but obviously if someone only has VMWare then a vagrant up would use VMWare by default so we wouldn't be able to detect that argument.

[rmccue]

these two aren't working

Are those working on master currently? I didn't change anything for non-NFS, so it seems like these have just always been broken...

[BronsonQuick]

Yeah they don't work in master. Chassis used to work in VMWare but that was pre-v2 I believe.

[rmccue]

Yeah they don't work in master.

Filed #409 to handle that since it's an existing issue; PR should be good to go, since it's not breaking anything that isn't already broken. :)

[BronsonQuick]

Seeing the two options for VMWare never worked let's merge this in.