[Accessibility] The Accept and Deny buttons for a new chat request don't have AccessibilityLabels

[MarcoZehe]

STR

1. Turn on VoiceOver in Settings/General/Accessibility. Take particular note of the changed gestures when VoiceOver is active.
2. Go into ChatSecure and have someone send you a contact request.
3. Read the request and the buttons.

Expected result

The buttons for Deny and Accept should speak what they do.

Actual result

Both buttons say "Button", without stating the purpose. The reason is probably that these are image buttons with no text label that UIAccessibility could use to put a label on.

How to fix

The easiest is a call to SetAccessibilityLabel on each button with a localized string that says something like "Accept" or "Authorize", and "Deny" or "Decline" respectively.

I don't have a Mac myself so can't contribute code, but ideally, this is a two-line fix plus translations.

[chrisballinger]

Thank you!

…

On Thu, Aug 23, 2018 at 1:39 AM Marco Zehe ***@***.***> wrote: STR 1. Turn on VoiceOver in Settings/General/Accessibility. Take particular note of the changed gestures when VoiceOver is active. 2. Go into ChatSecure and have someone send you a contact request. 3. Read the request and the buttons. Expected result The buttons for Deny and Accept should speak what they do. Actual result Both buttons say "Button", without stating the purpose. The reason is probably that these are image buttons with no text label that UIAccessibility could use to put a label on. How to fix The easiest is a call to SetAccessibilityLabel on each button with a localized string that says something like "Accept" or "Authorize", and "Deny" or "Decline" respectively. I don't have a Mac myself so can't contribute code, but ideally, this is a two-line fix plus translations. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1050>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAfqH_s7Abr3XwXmnywilUANCSHjvkU7ks5uTmorgaJpZM4WJFfe> .