Add clickable usernames in host offline messages #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me! Only gripe is that the username's capitalisation in "Now hosting" can differ to that of "has gone offline"
|
Not sure why this happens since both messages are handled similarly. Do you know if the original offline message we get (which is the one shown on the current version) has the username capitalized? Edit: The original messages seems to be different (commit f605221), PR only adds the link: |
pajlada
approved these changes
Jun 27, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Jun 28, 2021
Now we're on commit 6355742; Changes from upstream we pulled: - Minor: Channel name in `<channel> has gone offline. Exiting host mode.` messages is now clickable. (Chatterino#2922) - Minor: Added `/openurl` command. Usage: `/openurl <URL>`. Opens the provided URL in the browser. (Chatterino#2461, Chatterino#2926) - Bugfix: Fixed large timeout durations in moderation buttons overlapping with usernames or other buttons. (Chatterino#2865, Chatterino#2921)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Makes the channel name in
<channel> has gone offline. Exiting host mode.messages clickable.Implements missing functionality from #2752 which was described in #2655.