Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check live status for all closed channels with notifications at once #3442

Merged

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented Dec 30, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable
  • Execute multiple api calls and add a limit

Description

No more hundred API calls for channels not attached to a split.

@Mm2PL Mm2PL changed the title Use single api call for fake channels live fetching live status for all closed channels with notifications at once Dec 30, 2021
@Mm2PL Mm2PL changed the title live status for all closed channels with notifications at once Check live status for all closed channels with notifications at once Dec 30, 2021
@Mm2PL Mm2PL marked this pull request as ready for review December 30, 2021 15:47
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com>
@zneix zneix enabled auto-merge (squash) January 1, 2022 16:51
@zneix zneix merged commit ea462f9 into Chatterino:master Jan 1, 2022
@zneix zneix deleted the feature/use_single_api_call_for_fake_channels branch January 1, 2022 17:06
zneix added a commit to SevenTV/chatterino7 that referenced this pull request Jan 2, 2022
Now we're on commit 14d11b6; Changes from upstream we've pulled

- Minor: Add search to emote popup. (Chatterino#3404)
- Minor: Messages can now be highlighted by subscriber or founder badges. (Chatterino#3445)
- Bugfix: Fixed crash that could occur if the user opens/closes ChannelViews (e.g. EmotePopup, or Splits) then modifies the showLastMessageIndicator setting. (Chatterino#3444)
- Dev: Batch checking live status for channels with live notifications that aren't connected. (Chatterino#3442)
- Dev: Added /fakemsg command for debugging (Chatterino#3448)
- Dev: Notebook::select\* functions now take an optional `focusPage` parameter (true by default) which keeps the default behaviour of selecting the page after it has been selected. If set to false, the page is _not_ focused after being selected. (Chatterino#3446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants