Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public to Cache-Control header #418

Closed
wants to merge 1 commit into from
Closed

Conversation

nuuls
Copy link
Contributor

@nuuls nuuls commented Jan 23, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #418 (ed5c39b) into master (031b678) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   44.49%   44.49%           
=======================================
  Files         101      101           
  Lines        3713     3713           
=======================================
  Hits         1652     1652           
  Misses       2013     2013           
  Partials       48       48           
Impacted Files Coverage Δ
pkg/cache/middleware.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pajlada
Copy link
Member

pajlada commented Jan 23, 2023

After testing, this doesn't seem necessary. Your original PR did the trick, I was just missing some magic cloudflare settings. Specifically a page rule to enable caching on the link_resolver path since by default cloudflare doesn't cache json content types

@pajlada pajlada closed this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants