Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed collapse button #22

Merged
merged 1 commit into from
Aug 13, 2020
Merged

fixed collapse button #22

merged 1 commit into from
Aug 13, 2020

Conversation

mfmarlow
Copy link
Contributor

@mfmarlow mfmarlow commented Aug 3, 2020

I made the closeButton point to the close button on the new layout so when you click it it actually collapses chat.

ALazyMeme
ALazyMeme approved these changes Aug 9, 2020
Copy link
Collaborator

@ALazyMeme ALazyMeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh just found a slight issue with this. Check this gif: https://i.nuuls.com/MhbyD.gif

When I move the window, the chatterino extension will move to the other monitor very quickly and move back.

@mfmarlow
Copy link
Contributor Author

mfmarlow commented Aug 9, 2020

Ahh just found a slight issue with this. Check this gif: https://i.nuuls.com/MhbyD.gif

When I move the window, the chatterino extension will move to the other monitor very quickly and move back.

@ALazyMeme this appears to be an issue in #19

@ALazyMeme
Copy link
Collaborator

Ahh just found a slight issue with this. Check this gif: https://i.nuuls.com/MhbyD.gif

When I move the window, the chatterino extension will move to the other monitor very quickly and move back.

@ALazyMeme this appears to be an issue in #19

Ok cool, we should be good to merge this. I can create a new issue for the teleporting issue.

@mfmarlow
Copy link
Contributor Author

mfmarlow commented Aug 9, 2020

On further inspection, the problem appears to come from the delay between the extension communicating the updated x position to the Chatterino application. I think the fix for this is going to be in the application rather than the extension if it's fixable at all.

@fourtf fourtf merged commit 7b7b22d into Chatterino:master Aug 13, 2020
@mfmarlow mfmarlow deleted the collapse_btn branch August 16, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants