Added confirmation for usercard actions #2629
Conversation
|
I found that this crashes Chatterino when any action is confirmed. I'm not sure what causes this, I am new to QT and c++. |
| QMessageBox::Information, "Chatterino 2", | ||
| "Unfollow user?", QMessageBox::Yes | QMessageBox::No); | ||
| box->setAttribute(Qt::WA_DeleteOnClose); | ||
| if (box->exec() == QMessageBox::Yes) |
There was a problem hiding this comment.
Not a QT guru but I suspect blocking the UI with this call is your cause. Try using QObject::connect to connect to the clicked signal. See here for an example.
QT devs correct me if I'm wrong.
There was a problem hiding this comment.
This applies to all 4 usages of exec()
|
Closing the popup and showing a message box doesn't seem like the best UX to me. How about making a button that needs to be pressed twice instead? Here's a mock-up of what I mean: |
|
Since the create and delete follow endpoints are being deprecated I'm going to close this PR (https://discuss.dev.twitch.tv/t/deprecation-of-create-and-delete-follows-api-endpoints/32351). Went on vacation and completely forgot I made this. I might open another PR with the intended functionality for blocking a user if I have time and learn enough QT & C++ to do so 😄 |
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Asks the user if they want to follow/unfollow or block/unblock someone when in the usercard
Closes #1886.