Deprecated /(un)follow commands and respective usercard action

[zneix]

Pull request checklist:

• CHANGELOG.md was updated, if applicable

Description

As announced, /helix/users/follows endpoints have been decomissioned today.

CC #3076 #2629

[zneix]

For now, /follow and /unfollow have been marked as deprecated:

And for the time being, follow checkbox in usercard remains but it's permanently disabled:

This maybe isn't the ideal solution as it could confuse users, making them think they can still (un)follow and try to click the checkbox.
We could either:

1. Remove the checkbox and checking if current user follows the user of whom usercard is opened altogether.
2. Think of some alternative, like the one that @Mm2PL suggested:

Click to expand

[Felanbird]

Minor English loophole:
Twitch has taken away our ability to manage follows, not the quality of, or possibility to make changes for the endpoint.
https://wikidiff.com/ability/possibility

As for the changelog I'm indifferent in the usage of (un)follow 🤷

[Felanbird]

As for the future of the button, I'm going to put my vote for keeping the button with its ability show follow status as currently handled, but making the functionality return an error message, as done with the slash commands in this PR.

Possibly removing it in the future if we need button room for some reason.

[zneix]

but making the functionality return an error message, as done with the slash commands in this PR.

As I've stated in my comment under this PR:

follow checkbox in usercard remains but it's permanently disabled

Do you mean we should keep the functionality of the button but add error messages notifying users that (un)following failed or did you just overlook that part where I said it? I believe there should be no logic for event actions related to that button as it's gonna be literally cosmetic at this point (if we decide to keep it in the first place that is).

[Felanbird]

Do you mean we should keep the functionality of the button but add error messages notifying users that (un)following failed

Yes, I think if we keep the button it should at least do something indicating to users that the attempt failed, possibly something like this:

(I followed off-screen in browser chat)

I believe there should be no logic for event actions related to that button as it's gonna be literally cosmetic at this point (if we decide to keep it in the first place that is).

If we to remove the all logic we should just remove the button in its entirety, no need for a cosmetic button.

[Felanbird]

Works as intended, the only problem seems to be the loading time, you have hover the button for 1.5~ seconds before the prompt appears. It took me a while to actually get the prompt because I was clicking the "button" and and doing so resets the loading.

[pajlada]

Works as intended, the only problem seems to be the loading time, you have hover the button for 1.5~ seconds before the prompt appears. It took me a while to actually get the prompt because I was clicking the "button" and and doing so resets the loading.

That's unfortunately fairly tricky for us to solve without creating a new QCheckBox type and re-implementing it's click handler making it show the tooltip.

[Mm2PL]

About the usercard: maybe we could change the text color/effects. For example gray out the Follow text or cross it out. It's impossible to tell that you cannot follow people anymore

[pajlada]

All in favour of removing the checkbox?

[Mm2PL]

lgtm