Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attached Video Viewer #2805

Closed
wants to merge 25 commits into from
Closed

Attached Video Viewer #2805

wants to merge 25 commits into from

Conversation

goldbattle
Copy link
Contributor

@goldbattle goldbattle commented May 22, 2021 •
edited

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

I have been experimenting with including an internal / attached video player which would be docked alongside the chat. This would allow for a pretty seamless viewing and chatting experience if possible. I have gone and done a quick demo of what this could look like and it seems to only be a few modifications so far.

Originally I stumbled upon the StreamLinkerino project, but I want to make it a more first class feature. Here is an example screenshot of what I have so far:

image
image

What works:

  • Clicking the "three dots" menu option in the split opens a second window
  • This window will then stream via streamlink and the mpv player
  • Switching between tabs will change the stream to match

My current issues:

  • Non-hacky storage of variables / widget (where would I store these variables?)
  • How to "attach / dock" this second window to the chat so it resizes and min/maximized with the main window (how to handle the layout?)
  • Volume control (probably not very likely with how the stream is attached to the qt window)

Any suggestions or comments on directions would be most welcomed. Thanks again for the great project.

Edit: You can try out the preliminary builds here:
https://github.com/goldbattle/chatterino2/actions/runs/867344185

@goldbattle goldbattle mentioned this pull request May 22, 2021
Open
@TranRed
Copy link
Contributor

TranRed commented May 23, 2021 

* Switching between tabs will change the stream to match

This sounds really bad for proxy and offline chatters, who chat in other channels while watching streams. Also what will it do if you have 2 or more channels in a tab. Which one will it open? The first one?

@goldbattle
Copy link
Contributor Author

goldbattle commented May 23, 2021 •
edited

If the tab is a non-live stream, the stream will still be the last live stream a person clicks on.
Then if a user clicks on another live stream then it will switch.

I should make this a toggle in the settings to disable auto switch.
The original motivation was to clearly keep the video in sync with what chat you seeing.
image

pajlada and others added 4 commits May 23, 2021 23:10
@pajlada
Add missing includes for those not using precompiled headers (Chatter…
108b733 
…ino#2815)
@zneix @leon-richardt
@nouryxd @pajlada
Add chat popout command (Chatterino#2812)
88a4875 
Co-authored-by: Paweł <zneix@zneix.eu>
Co-authored-by: Leon Richardt <leon.richardt@gmail.com>
Co-authored-by: lyx0 <stefan.parfuss@protonmail.ch>
Co-authored-by: lyx0 <66651385+lyx0@users.noreply.github.com>
Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
@zneix
Remove unused legacy issue template file (Chatterino#2820)
7659dc2
@fourtf @pajlada
optimize chatter list (Chatterino#2814)
3fddafb 
* optimize chatter list

* changelog

* Fix tests

Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
@zneix zneix self-requested a review May 26, 2021 18:29
dependabot bot and others added 13 commits May 29, 2021 11:06
@dependabot
Bump actions/cache from 2.1.5 to 2.1.6 (Chatterino#2830)
708670b 
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.5 to 2.1.6.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.5...v2.1.6)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump ilammy/msvc-dev-cmd from 1.8.0 to 1.8.1 (Chatterino#2828)
7e4f8be 
Bumps [ilammy/msvc-dev-cmd](https://github.com/ilammy/msvc-dev-cmd) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/ilammy/msvc-dev-cmd/releases)
- [Commits](ilammy/msvc-dev-cmd@v1.8.0...v1.8.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jupjohn @zneix @pajlada
Match game names exactly when using /setgame (Chatterino#2825)
faae2c2 
Co-authored-by: Paweł <zneix@zneix.eu>
Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
@talneoran
Fix tab direction not applying to popup window (Chatterino#2839)
01bda9c
@zneix @leon-richardt @pajlada
Added ability to toggle visibility of tabs (Chatterino#2600)
5735428 
This can be done by right-clicking the tab area or pressing the keyboard shortcut (default: Ctrl+U).

Co-authored-by: Leon Richardt <leon.richardt@gmail.com>
Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com>
@zneix
Fix links on Windows building docs (Chatterino#2848)
508fea6 
* Fixed OpenSSL 1.1.1 version

* Switched to sourceforge downloads from bintray as it has been shutdown

* FeelsDankMan how to english
@goldbattle
Mention how to build with conan
bd40651
@goldbattle
Simple rough demo of side video player
645fa43
@goldbattle
Add settings for MPV player path.
5c7617b
@goldbattle
Update settings.
8fddebf
@goldbattle
Handle case if attached window is exited, thus relaunch if requested.
42fe7c9
@goldbattle
Mention how to build with conan
1beced2
@goldbattle
Merge remote-tracking branch 'goldbattle/master'
e97f0ea
zneix
zneix requested changes Jun 2, 2021
View reviewed changes
Copy link
Collaborator

@zneix zneix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to build.yml, .gitignore and BUILDING_ON_WINDOWS.md are totally unrelated, please revert those.

@goldbattle
Copy link
Contributor Author

I screwed it up as I was experimenting with doing rebase merging from the master branch.
I will re-open a new PR after I make some more changes and experiment a bit more.
Sorry for the notifications.

@goldbattle goldbattle closed this Jun 2, 2021
@goldbattle goldbattle deleted the master branch June 2, 2021 19:48
@goldbattle goldbattle mentioned this pull request Jun 3, 2021
Closed
1 task
@goldbattle
Copy link
Contributor Author

I created another non-draft PR here, sorry to those that got the extra ping in this one.
#2854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zneix zneix zneix requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@goldbattle @TranRed @leon-richardt @zneix @talneoran @fourtf @Mm2PL @pajlada @jupjohn