Communicate streams that went offline through /live #2880
Conversation
There was a problem hiding this comment.
LGTM, but wouldn't it be better to just gray out the previous channel is online message instead maybe (in the /live split)?
I feel like that would make more sense in a /live tab since you'll have a lot of channels going live or offline so it might be hard to track if a channel went offline or is still live.
There was a problem hiding this comment.
Overall the PR looks good and does its job well 👍
wouldn't it be better to just gray out the previous channel is online message instead maybe
I agree with apa on this one though. it will get very unclear and hard to follow/connect messages related to one channel and another.
I really like this idea. I didn't even think of such a possibility. Thank you for pointing this out. I'll be sure to add this. |
|
Only con with the approach I suggested is you won't know when they went offline. But to be fair this is called a /live split so I think it's fine it's left out. |
Mm2PL
changed the title
|
Just spitballing some ideas, maybe striking through the messages (instead of)|(in addition to) graying them out could also be a possibility? Might make it a little more noticeable |
|
Also accidentally fixes #2791. |
I've looked into this. This requires a bunch of changes to rendering fonts. Currently the function that renders text doesn't need to know anything about the outside world like should this message have text be struck-through. |
|
It would also be nice if when a stream goes offline, it reports the up time so the user can know how long of a stream they missed. |
This is not trivial to achieve since the easily accessible timestamp of "going live" we have might be the same time we started Chatterino. |
Now we're on commit d6b5921; Changes from upstream we pulled: - Major: Added username autocompletion popup menu when typing usernames with an @ prefix. (Chatterino#1979, Chatterino#2866) - Minor: The /live split now shows channels going offline. (Chatterino#2880) - Minor: Now shows deletions of messages like timeouts (Chatterino#1155, Chatterino#2841, Chatterino#2867, Chatterino#2874) - Bugfix: Moderation buttons now show the correct time unit when using units other than seconds. (Chatterino#1719, Chatterino#2864) - Bugfix: Fixed bit and new subscriber emotes not (re)loading in some rare cases. (Chatterino#2856, Chatterino#2857)
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Adds
channel is now offline.messages to the/livechannel. Closes #2799. Fixes #2791