Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-message phrases to be highlighted by self #3835

Merged
merged 4 commits into from
Jun 26, 2022

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Jun 25, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Fixes #3814

All non-phrase highlights can now trigger on messages from self
New state:
Allows self highlights: Subscription, Whisper, User, Badge
Does not allow self highlights: Message

New state:
Allows self highlights: Subscription, Whisper, User, Badge
Does not allow self highlights: Message
@pajlada pajlada changed the title Fix self-highlight logic Allow non-message phrases to be highlighted by self Jun 25, 2022
@goldbattle
Copy link
Contributor

This fixes the self highlight for me when I specify myself as a user to be highlighted.
Windows 10 using chatterino-windows-x86-64-5.12.12-cmake.zip
image

@pajlada pajlada enabled auto-merge (squash) June 26, 2022 10:23
@pajlada pajlada merged commit 8bdfbf7 into master Jun 26, 2022
@pajlada pajlada deleted the fix/user-highlights-not-triggering-for-self branch June 26, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

self user highlights no longer working
2 participants