Fix empty page added when showing OOB dialog #4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fun kind-of-but-not-really concurrency problem. The dialog is shown by using
QDialog::exec, which creates an additional event-loop. This event-loop will handle the dialog events. One event happens when the dialog is activated/shown, which deactivates the last active window. Since the window is created before the dialog is shown, it gets deactivated. Deactivating the main window will causeWindow::eventto be called, which adds a page, since there are no pages at that point.Technically, the fix could also move the window creation, but the handler for
QEvent::WindowDeactivatedoesn't need to callgetOrAddSelectedPagein the first place.Fixes #3571.