Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to duplicate tabs #5277
Add feature to duplicate tabs #5277
Changes from 4 commits
3660d5a
1cd45ee
be1e67e
e786dc1
3d836c3
97b7eea
a87da55
7058ccf
ff2b728
4b9f3f7
09b0f7a
6741f2e
4eec87e
a0ff5fa
d702333
f5f5549
a408bf4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pajlada @Nerixyz not sure why but there is a
Channel::Type
insideIndirectChannel
and insideChannel
, and they are not matching hereThe reason being that when the
watchingChannel
is created, it gets passed an empty channel that has typeNone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type of the IndirectChannel is the type of indirection. It's really only for the watching channel. Its type is only ever
TwitchWatching
orDirect
(don't quote me on that). Maybe there should be another type for the type of indirection, but it's easier for saving/restoring right now, I suppose.If you use
getIndirectChannel().getType()
instead ifgetChannel()->getType()
it seems to work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
descriptor building doesn't handle empty nodes rn, so trying to duplicate empty tab (
Node::Type::EmptyRoot
) will crash here because split is null. We probably should allow that for ux consistencyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, my alias did a bit of trolling. Didn't realize someone else pushed to the branch. Not sure if there is an easy way for me to recover it now that the commit is orphan
Makes sense, I'll add a check for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you know the SHA, you can append
.diff
or.patch
to the commit's URL on GitHub - for example https://github.com/Chatterino/chatterino2/commit/44f22f732559ab3065d5fcadb33028b3ad5faec8.patch.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could get the changes from a patch and make a new commit out of that, is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We commented basically at the same time lol. Yeah, I will do that and add a new commit with pajlada's changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patches are fine, rebasing onto 44f22f7 should also work or cherry picking skipped commits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to find the commits by fetching (I guess because they aren't on any branch) so
cherry-pick
wasn't working