Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: About page #5287

Merged
merged 10 commits into from
Mar 31, 2024
Merged

refactor: About page #5287

merged 10 commits into from
Mar 31, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Mar 31, 2024

Refactors the about page. The main change is about the layout of contributors, which are now in a flow layout with headings. I've pretty much copied the example from Qt and adjusted it to fit the needs.
Contributors without an image now get a default image. Since I wasn't sure which one to use, I've included two:

anon.png anon2.png
firefox_2024-03-31_13-22-52

Additionally, I've made the following changes:

  • Added word-wrap for the version label (it would overflow for me, creating a horizontal scrollbar)
  • Added a missing space in the emoji datasource
  • Renamed "Contributors" to "People" (since there's already a category of contributors)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/layout/FlowLayout.cpp Show resolved Hide resolved
src/widgets/layout/FlowLayout.cpp Show resolved Hide resolved
src/widgets/layout/FlowLayout.cpp Show resolved Hide resolved
src/widgets/layout/FlowLayout.cpp Show resolved Hide resolved
src/widgets/layout/FlowLayout.cpp Show resolved Hide resolved
src/widgets/layout/FlowLayout.cpp Show resolved Hide resolved
src/widgets/layout/FlowLayout.cpp Show resolved Hide resolved
src/widgets/layout/FlowLayout.cpp Show resolved Hide resolved
src/widgets/layout/FlowLayout.cpp Show resolved Hide resolved
src/widgets/layout/FlowLayout.hpp Show resolved Hide resolved
Some day my pc will be fast enough to disable PCH
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/layout/FlowLayout.cpp Show resolved Hide resolved
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

src/widgets/settingspages/AboutPage.cpp Outdated Show resolved Hide resolved
src/widgets/settingspages/AboutPage.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/widgets/settingspages/AboutPage.cpp Outdated Show resolved Hide resolved
src/widgets/settingspages/AboutPage.cpp Outdated Show resolved Hide resolved
@pajlada pajlada enabled auto-merge (squash) March 31, 2024 21:44
@pajlada pajlada merged commit 905aa4e into Chatterino:master Mar 31, 2024
17 checks passed
@Nerixyz Nerixyz deleted the refactor/contributors branch April 1, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants