-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(resolver): recover panic during resolve #6511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kindly add tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
Maybe good to add logging that allows users to see on which file the analysis choked if any parsing issues remain. That will make troubleshooting a lot easier for future parsing-related issues. As can be seen in #6513, the stacktrace did not provide any helpful information on which file the analysis broke. Would make future troubleshooting a lot more efficient. |
@p3pijn , you right! we will add your idea into our future implementations! thanks for your input! |
Proposed Changes
I submit this contribution under the Apache-2.0 license.