Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resolver): recover panic during resolve #6511

Merged
merged 7 commits into from
Jul 18, 2023
Merged

fix(resolver): recover panic during resolve #6511

merged 7 commits into from
Jul 18, 2023

Conversation

cxMiguelSilva
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva commented Jul 11, 2023 •
edited

Proposed Changes

  • add panic handling for the resolve process

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva changed the title FIx reference check in json resolver fix(resolver): handle check in json resolver Jul 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023 •
edited

kics-logo

KICS version: v1.7.0

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 1
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 1
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

@cxMiguelSilva cxMiguelSilva changed the title fix(resolver): handle check in json resolver fix(resolver): handle check in json resolver and handle panic during resolve Jul 11, 2023
@cxMiguelSilva cxMiguelSilva mentioned this pull request Jul 12, 2023
Closed
@gabriel-cx gabriel-cx mentioned this pull request Jul 12, 2023
Closed
gabriel-cx
gabriel-cx suggested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@gabriel-cx gabriel-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly add tests

@cxMiguelSilva cxMiguelSilva changed the title fix(resolver): handle check in json resolver and handle panic during resolve fix(resolver): recover panic during resolve Jul 17, 2023
@cxMiguelSilva cxMiguelSilva marked this pull request as ready for review July 17, 2023 11:07
pereiramarco011
pereiramarco011 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@pereiramarco011 pereiramarco011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@p3pijn
Copy link

p3pijn commented Jul 18, 2023

Maybe good to add logging that allows users to see on which file the analysis choked if any parsing issues remain. That will make troubleshooting a lot easier for future parsing-related issues. As can be seen in #6513, the stacktrace did not provide any helpful information on which file the analysis broke. Would make future troubleshooting a lot more efficient.

@gabriel-cx
Copy link
Contributor

@p3pijn , you right! we will add your idea into our future implementations! thanks for your input!

@asofsilva asofsilva merged commit 5c74cf1 into master Jul 18, 2023
13 checks passed
@asofsilva asofsilva deleted the kics/894 branch July 18, 2023 13:44
@Porkepix Porkepix mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-cx gabriel-cx gabriel-cx approved these changes

@pereiramarco011 pereiramarco011 pereiramarco011 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cxMiguelSilva @p3pijn @gabriel-cx @pereiramarco011 @asofsilva