Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-owner shops #133

Open
danisaacs opened this issue May 16, 2018 · 3 comments
Open

Multi-owner shops #133

danisaacs opened this issue May 16, 2018 · 3 comments
Labels
addon For issues with ChestShop addons or enhancements better suited to be added via an addon enhancement For addition requests

Comments

@danisaacs
Copy link

Not an issue, so much as a feature request.

Enable multiple users. Given the limited real estate on a sign, this may be something that requires a group be created that an admin can add users to. Revenue % could be configured in the group file (custom percentages or default of $/# of user in group paid to each member)

Use case, if not obvious, is that it would automate revenue or cost sharing. As an example:

Shop named "DanShop", run by danisaacs and queenherp. Shop signs could have "DanShop" in the top line. Config file lists group "DanShop" with the 2 members above, each getting 50% of revenue. For each transaction, the plugin divides the $ by the percentage, and applies to each member's /balance.

Permissions would also reference the group membership, so that all users could access the chests to restock.

The custom % would allow shops to have workers paid for labor outside of the plugin. Eg. danisaacs could pay 814bro a flat rate to restock shop chests from storage. 814Bro would belong to group for permissions, but get 0% of revenue.

@Phoenix616
Copy link
Member

The idea of multi-owner shops has been around for a while but there isn't really a nice way of doing that with the philosophy of the plugin to contain all information about a shop directly on the sign and not requiring any commands/special config settings to use it. A part of the solution could be to do that via bank accounts (see #119) and to manage the access control via the bank account provider.

Another possibility could also be for another plugin to implement this functionality, ChestShop has lots of events that should make it possible to implement such a functionality via another separate module/plugin.

@Phoenix616 Phoenix616 added the enhancement For addition requests label May 25, 2018
@Phoenix616 Phoenix616 mentioned this issue May 3, 2019
@Pajlis
Copy link

Pajlis commented May 10, 2019

If you do somehow put in this feature.. aka something like /chestshop add - add players access your shop.. could there also be a command to show like /chestshop list that shows all the players who have access to your shop.

My server atm.. i am using a skript system to do this (which im not a pro at anyways but it works).. If this is implemented it would be really cool. Most of my players care less about the money but rather the idea of just sharing shops with players. And thanks for the idea of using lwc donation system seems very cool too!

@Phoenix616
Copy link
Member

If this system would be added then a way to query users that have access would be included too, yes. Seeing as this might go beyond what ChestShop itself wants to do (easy shops by creating signs and not having to fiddle with commands at all) this might not get implemented in the plugin itself.

It should be easily possible to do that with an extension plugin and ChestShop's events though. Using LWC the ability to have multiple people access the shop chest can even already be achieved. (But not the "give money to multiple people" part)

Phoenix616 added a commit that referenced this issue May 2, 2020
This should be the final addition that allows other plugins to implement
multi-owner/group shops like requested in #119 and #133 by listening to
all the transaction events to handle money flow and shop/account access
events to enable access to the actual shop.
@Phoenix616 Phoenix616 added the addon For issues with ChestShop addons or enhancements better suited to be added via an addon label Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon For issues with ChestShop addons or enhancements better suited to be added via an addon enhancement For addition requests
Projects
None yet
Development

No branches or pull requests

3 participants