Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SparseTimeFunction coordinates are set properly with MPI -- add unit test #82

Merged
merged 1 commit into from
Apr 22, 2022
Merged

SparseTimeFunction coordinates are set properly with MPI -- add unit test #82

merged 1 commit into from
Apr 22, 2022

Conversation

jkwashbourne
Copy link
Contributor

Previous tests for SparseTimeFunction coordinates with MPI were round trip only, this tests that coords OK in python land.

samtkaplan
samtkaplan requested changes Apr 22, 2022
View reviewed changes
Copy link
Member

@samtkaplan samtkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the @test_skip's still need removing.

@jkwashbourne
Copy link
Contributor Author

removed the @test_skip and squashed/rebased

@jkwashbourne jkwashbourne merged commit d606e4e into master Apr 22, 2022
@jkwashbourne jkwashbourne deleted the add_mpi_coords_test branch April 22, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtkaplan samtkaplan samtkaplan requested changes

@deckerla deckerla Awaiting requested review from deckerla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkwashbourne @samtkaplan