Allow AffinePoint to be correctly turned into bytes #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariano54
approved these changes
Sep 19, 2022
ayrtondutchman
force-pushed
the
main
branch
from
7a82d27
to
2d70eaf
Compare
|
@mariano54 thanks for reviewing. I saw that it couldn't be merged because of something called vigilant mode. Which was new to me. Now that I have read up about it. I think I have been able to sign the older commit. (Was a bit of a hassle as you can see) Now I was wondering if the workflows could get re-approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday I was messing around with bls-signatures python impl and bindings and noticed that in the python impl when a AffinePoint is turned into bytes it doesn't handle it like it handles a JacobianPoint turned into bytes. Even though the process is exactly the same as the first thing that is done to the Jacobian is it is turned into Affine.