fix:UB with reading unitialized data in tests of "class PrivateKey" #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
changed the title
|
'This PR has been flagged as stale due to no activity for over 60 |
arvidn
approved these changes
May 8, 2023
arvidn
requested changes
May 8, 2023
| @@ -56,7 +56,6 @@ void TestHKDF(string ikm_hex, string salt_hex, string info_hex, string prk_expec | |||
|
|
|||
| TEST_CASE("class PrivateKey") { | |||
| uint8_t buffer[PrivateKey::PRIVATE_KEY_SIZE]; | |||
| memcmp(buffer, getRandomSeed().data(), PrivateKey::PRIVATE_KEY_SIZE); | |||
There was a problem hiding this comment.
I believe this was intended to say memcpy()
|
Done here: #370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This call
memcmpis quite useless, because result is not used and more over it reads an un-itialized data.