Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rid of UB and memory leak based on clang warnings #67

Closed
wants to merge 2 commits into from

Conversation

knst
Copy link

@knst knst commented Feb 20, 2023

  • fixed UB with reading unitialized data from buffer and compare by memcmp
  • fix: add missing final and virtual destructor to avoid memory leak.

It also removes several clang's warnings during build.

@PastaPastaPasta
Copy link
Member

I think this should be done upstream

@github-actions
Copy link

'This PR has been flagged as stale due to no activity for over 60
days. It will not be automatically closed, but it has been given
a stale-pr label and should be manually reviewed.'

@knst
Copy link
Author

knst commented Apr 25, 2023

@PastaPastaPasta that 2 PR are dead in Chia's repo.

Can you review and merge this PR instead waiting them get merged and backported later?

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should backport Chia-Network#370 and Chia-Network#371

@UdjinM6 UdjinM6 mentioned this pull request Jun 10, 2023
@UdjinM6
Copy link

UdjinM6 commented Jun 10, 2023

superseded by #83

@UdjinM6 UdjinM6 closed this Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants