Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing destructor for CoreMPL and final for nested classes #359

Closed
wants to merge 1 commit into from

Commits on Feb 23, 2023

  1. fix: add missing destructor for CoreMPL and final for nested classes

    There is no actual memory leak because no data in the the CoreMPL
    
    But it resolves clang's warning:
    
        /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/unique_ptr.h:95:2: warning: delete called on non-final 'bls::CoreMPL' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor]
                delete __ptr;
                ^
        /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/unique_ptr.h:396:4: note: in instantiation of member function 'std::default_delete<bls::CoreMPL>::operator()' requested here
                  get_deleter()(std::move(__ptr));
                  ^
        main.cpp: note: in instantiation of member function 'std::unique_ptr<bls::CoreMPL>::~unique_ptr' requested here
        static const std::unique_ptr<bls::CoreMPL> pSchemeMLP{std::make_unique<bls::BasicSchemeMPL>()};
    knst committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    ac30541 View commit details
    Browse the repository at this point in the history