Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend pools test workflow timeout to 60 minutes #10271

Merged
merged 1 commit into from
Feb 17, 2022
Merged

extend pools test workflow timeout to 60 minutes #10271

merged 1 commit into from
Feb 17, 2022

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Feb 17, 2022 •
edited
Loading

Recent runs on main have been taking over 40 minutes.

hoffmang9
hoffmang9 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh...

@altendky
Copy link
Contributor Author

We're talking about what we can do to speed up the tests... but we also need to get coverage in and that doesn't exactly make things faster.

@hoffmang9
Copy link
Member

Totally. Hence approve with a sigh.

@wjblanke wjblanke merged commit 5d2770c into main Feb 17, 2022
@wjblanke wjblanke deleted the pools_timeout_to_60 branch February 17, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffmang9 hoffmang9 hoffmang9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@altendky @hoffmang9 @wjblanke