Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use context manager for locking clvm files #11467

Merged
merged 1 commit into from
May 10, 2022
Merged

Use context manager for locking clvm files #11467

merged 1 commit into from
May 10, 2022

Conversation

altendky
Copy link
Contributor

@altendky altendky commented May 7, 2022 •
edited

Context managers for this form avoid needing to create a callable and having to pass it through another function.

Also note that we have intend to use the filelock library in the future so our own locking mechanism could be replaced by that.

@altendky altendky added the example reference example for coding form label May 7, 2022
@altendky altendky added the ready_to_merge Submitter and reviewers think this is ready label May 10, 2022
@wjblanke wjblanke merged commit 6788c0a into main May 10, 2022
@wjblanke wjblanke deleted the more_context_management branch May 10, 2022 11:42
@altendky altendky restored the more_context_management branch May 10, 2022 18:41
@altendky altendky deleted the more_context_management branch May 13, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xdustinface xdustinface xdustinface approved these changes

@prozacchiwawa prozacchiwawa Awaiting requested review from prozacchiwawa

Assignees
No one assigned
Labels
example reference example for coding form ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@altendky @xdustinface @wjblanke