Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove support for Python 3.7 #14611

Merged
merged 6 commits into from
Jul 14, 2023
Merged

remove support for Python 3.7 #14611

merged 6 commits into from
Jul 14, 2023

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Feb 17, 2023 •
edited
Loading

Purpose:

Drop support for and testing of Python 3.7 as it is EOL. This does not update idioms etc meant to handle 3.7.

Current Behavior:

New Behavior:

Testing Notes:

Draft For:

  • discussing the actual timing of removal now that 3.7 has been deprecated
  • consider requiring 3.8.1 such as for pin keyring==23.9.3 #14549
  • adjust for requiring 3.8.1+

Followups:

@altendky altendky added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Feb 17, 2023
@altendky altendky mentioned this pull request Feb 22, 2023
Merged
1 task
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Feb 22, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

AmineKhaldi added a commit to AmineKhaldi/chia-blockchain that referenced this pull request Feb 22, 2023
@AmineKhaldi
PR Chia-Network#14611 didn't land yet (keep 3.7 support for now).
1b04a09
wallentx pushed a commit that referenced this pull request Feb 23, 2023
@AmineKhaldi
Introduce BlockRecordProtocol as a subset of BlockRecord that the mem…
b019fe5 
…pool manager uses for peak (#14628)

* Introduce BlockRecordProtocol as a subset of BlockRecord that the mempool manager uses for peak.

* Create BenchBlockRecord and use it for benchmarks/mempool.py.

* PR #14611 didn't land yet (keep 3.7 support for now).

* We don't need this guidance anymore.
@github-actions
Copy link
Contributor

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Apr 11, 2023
emlowe pushed a commit that referenced this pull request Apr 11, 2023
@AmineKhaldi @emlowe
Introduce BlockRecordProtocol as a subset of BlockRecord that the mem…
28d5461 
…pool manager uses for peak (#14628)

* Introduce BlockRecordProtocol as a subset of BlockRecord that the mempool manager uses for peak.

* Create BenchBlockRecord and use it for benchmarks/mempool.py.

* PR #14611 didn't land yet (keep 3.7 support for now).

* We don't need this guidance anymore.
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 13, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@altendky altendky mentioned this pull request Jul 13, 2023
Merged
@altendky altendky marked this pull request as ready for review July 13, 2023 17:19
@altendky altendky requested a review from a team as a code owner July 13, 2023 17:19
@altendky altendky requested a review from wjblanke July 13, 2023 20:27
wjblanke
wjblanke approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Jul 14, 2023
@wallentx wallentx merged commit 42a6d1a into main Jul 14, 2023
197 checks passed
@wallentx wallentx deleted the drop_python_3.7 branch July 14, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

@cmmarslender cmmarslender cmmarslender approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready stale-pr Flagged as stale and in need of manual review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@altendky @wjblanke @cmmarslender @arvidn @wallentx