Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mutiproc prevalidation #15166

Merged
merged 7 commits into from May 12, 2023
Merged

Refactor mutiproc prevalidation #15166

merged 7 commits into from May 12, 2023

Conversation

almogdepaz
Copy link
Contributor

Purpose:

simplify pre_validate_blocks_multiprocessing, avoid redundant serialisations

Current Behavior:

New Behavior:

Testing Notes:

@almogdepaz almogdepaz added tech-debt Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog labels May 1, 2023
@almogdepaz almogdepaz requested a review from altendky May 1, 2023 11:58
@almogdepaz almogdepaz marked this pull request as ready for review May 3, 2023 08:59
@almogdepaz almogdepaz requested a review from a team as a code owner May 3, 2023 08:59
@almogdepaz almogdepaz requested a review from fchirica May 8, 2023 09:56
@emlowe emlowe requested review from arvidn and xdustinface May 9, 2023 15:12
arvidn
arvidn previously approved these changes May 9, 2023
View reviewed changes
chia/consensus/multiprocess_validation.py Outdated Show resolved Hide resolved
@wallentx wallentx dismissed arvidn’s stale review May 9, 2023 19:57

Spoke with Almog, and he's going to make changes based on Arvid's comments. Dismissing so I don't accidentally merge.

@almogdepaz almogdepaz requested a review from arvidn May 10, 2023 09:03
arvidn
arvidn approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@wallentx wallentx merged commit 148a8eb into main May 12, 2023
195 checks passed
@wallentx wallentx deleted the refactor_mutiproc_prevalidation branch May 12, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@altendky altendky Awaiting requested review from altendky

@fchirica fchirica Awaiting requested review from fchirica

@xdustinface xdustinface Awaiting requested review from xdustinface

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@almogdepaz @arvidn @wallentx