Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint to CAT change #15179

Merged
merged 5 commits into from May 4, 2023
Merged

Hint to CAT change #15179

merged 5 commits into from May 4, 2023

Conversation

Quexington
Copy link
Contributor

This PR would start making the CAT wallet hint to its change outputs which it does not do currently. This should not fix anything necessarily right now, but is a good idea for the future as we try to make the wallet sync more robust.

@Quexington Quexington marked this pull request as ready for review May 2, 2023 19:07
@Quexington Quexington requested a review from a team as a code owner May 2, 2023 19:07
@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label May 2, 2023
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 3, 2023
Copy link
Contributor

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the tests are failing, looks like you need to adjust some more asserts.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 3, 2023
@Chia-Network Chia-Network deleted a comment from github-actions bot May 3, 2023
@Chia-Network Chia-Network deleted a comment from github-actions bot May 3, 2023
@wallentx wallentx merged commit 0346bdd into main May 4, 2023
197 checks passed
@wallentx wallentx deleted the quex.hint_to_change branch May 4, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants