Fix #13393 offer shows network's XCH like TXCH on testnet10 #15224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Fixes #13393
#13393 is currently assigned to @paninaro however I picked it up thinking it was assigned to force the issue to stay open instead of being closed for staleness.
I also thought it'd be a relatively straight forward issue for me to contribute for 馃
This PR is something I roughed in. I'm very open to changing anything about it.
It is rough like:
print_offer_summary(...)
signatureload_config
in again seemed like an anti-pattern in looking at how the lifecycle of commands would do that once at the top levelAddressType.XCH.hrp()
to getXCH
||TXCH
take_offer(...)
does already use this for generating the correct addressnetwork_xch
which I am not attached to and think there could be named something betterCurrent Behavior:
When using
chia wallet take_offer
ontestnet10
the summary will print like:or when there are royalties like:
New Behavior:
When using
chia wallet take_offer
ontestnet10
the summary will print like:and with royalties like:
Testing Notes:
The extent of my testing was running 2 offers with
chia wallet take_offer -e offer...
:One I had from using the tibetswap v2 test, made up of CATs and TXCH
One I pulled from a recent dexie.space testnet NFT trade.
I did not run the test suite.