Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass VC fee parameter all the way through and check balances in tests #15286

Merged
merged 1 commit into from May 16, 2023

Conversation

Quexington
Copy link
Contributor

The fee for VC minting wasn't being properly passed through to the drivers from the wallet. This PR fixes that as well as adds better balance checks throughout the vc wallet tests.

@Quexington Quexington marked this pull request as ready for review May 15, 2023 16:38
@Quexington Quexington requested a review from a team as a code owner May 15, 2023 16:38
@Quexington Quexington changed the title Pass fee all the way through and check balances in tests Pass VC fee parameter all the way through and check balances in tests May 15, 2023
@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label May 15, 2023
@trepca trepca added the ready_to_merge Submitter and reviewers think this is ready label May 15, 2023
@arvidn
Copy link
Contributor

arvidn commented May 15, 2023

@Quexington Quexington removed the ready_to_merge Submitter and reviewers think this is ready label May 15, 2023
@Quexington
Copy link
Contributor Author

Quexington commented May 15, 2023

this looks like it might be a typo: https://github.com/Chia-Network/chia-blockchain/actions/runs/4982911345/jobs/8922520892?pr=15286#step:17:55

That error actually shows up on pretty much every wallet test, I've kinda just forgotten it. The line below it is actually evidence of an error though which I will fix in a separate PR (#15289) making the test flaky.

@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 4982911345

  • 19 of 19 (100.0%) changed or added relevant lines in 1 file are covered.
  • 52 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.04%) to 85.078%

Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 77.11%
chia/harvester/harvester_api.py 1 66.67%
chia/wallet/cat_wallet/cat_wallet.py 1 89.83%
chia/wallet/util/wallet_sync_utils.py 1 66.91%
chia/data_layer/data_store.py 2 93.6%
chia/data_layer/download_data.py 2 64.2%
chia/timelord/timelord_launcher.py 3 57.14%
chia/server/node_discovery.py 4 77.94%
chia/wallet/wallet_state_manager.py 5 94.41%
chia/wallet/wallet_node.py 7 85.97%
Totals Coverage Status
Change from base Build 4982160439: -0.04%
Covered Lines: 75764
Relevant Lines: 88869

💛 - Coveralls

@wallentx wallentx merged commit 598450f into main May 16, 2023
202 of 203 checks passed
@wallentx wallentx deleted the quex.vc_mint_fee branch May 16, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants