Repin clvm_tools_rs==0.1.34 #15455
Merged
Repin clvm_tools_rs==0.1.34 #15455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Fixed
arvidn
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should mainly fix the problem with CLVM constantly recompiling during pytest runs. However, in an update to the compiler, hex files are now emitted with a new line (just a
\nnot a\r\non Windows). This means we also had to update all of those, but if you hide whitespace in the diff you can verify that this is the only thing that has changed. However this will result in a bit of tumult for people pulling main after this change because they will have to rebuild their venv in order to pass the pre-commit check.