Clawback resync #15496

ytx1991 · 2023-06-13T05:20:53Z

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

chia/wallet/wallet_state_manager.py

xdustinface · 2023-06-13T20:58:20Z

Reopening because CI obviously only run conflicts checks here.

chia/wallet/wallet_state_manager.py

ytx1991 · 2023-06-16T16:07:06Z

This fix is not necessary for the release, close for now

xdustinface · 2023-06-20T19:05:40Z

@ytx1991 The test you added in 91ac933 doesn't seem to pass. It still running on CI but times out here locally with the following:

21:02:20 chia.wallet.wallet_node: INFO Selected multiprocessing start method: default
21:02:20 chia.wallet.wallet_node: INFO Resetting wallet sync data...
21:02:20 chia.wallet.wallet_node: INFO Reset wallet sync data completed.
21:02:20 chia.wallet.wallet_node: DEBUG Trying to disable resync: 2999502625 [2999502625]
21:02:20 chia.wallet.wallet_node: INFO Disabled resync for wallet fingerprint: 2999502625
21:02:20 chia.wallet.wallet_state_manager: DEBUG Starting in db path: /private/var/folders/6b/sb101ygd0_xfxmbc_ljxybr80000gn/T/tmprryrmaxf/test-wallet-db-None-2999502625.sqlite
21:02:20 chia.wallet.wallet_node: INFO Wallet is logged in using key with fingerprint: 2999502625
21:02:20 chia.wallet.wallet_node: INFO Updated last used fingerprint: 2999502625
21:02:20 chia.wallet.did_wallet.did_wallet: INFO Confirmed balance for did wallet is 0
21:02:20 chia.wallet.did_wallet.did_wallet: INFO Confirmed balance for did wallet is 0
FAILED
tests/wallet/rpc/test_wallet_rpc.py:1907 (test_fully_resync[True])
tests/wallet/rpc/test_wallet_rpc.py:1980: in test_fully_resync
    await time_out_assert(20, wc2.get_synced)
E   AssertionError: Timed assertion timed out after 22 seconds: expected True, got False

chia/wallet/wallet_state_manager.py

chia/wallet/util/transaction_type.py

xdustinface

There is still a leftover from the retargeting to main and two nits.

.github/workflows/test.yml

chia/wallet/wallet_state_manager.py

tests/wallet/rpc/test_wallet_rpc.py

chia/wallet/wallet_state_manager.py

danieljperry

I cloned main and added this PR. I'm having trouble getting auto claim to work. This video shows when it fails (I did cut out a lot where nothing was happening, but I didn't cut the auto claim part):

Clawback.Autoclaim.main+15496.mp4

Here's my log from when the claim happened:

auto_claim.txt

danieljperry · 2023-06-29T18:18:45Z

Here's another issue I saw while attempting to claw back a transaction. Note that this problem might not be related to this PR:

nonetype.mp4

Log snippet:

Traceback (most recent call last):
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\wallet_rpc_api.py", line 912, in get_transactions
    assert record is not None, f"Cannot find coin record for clawback transaction {tx['name']}"
AssertionError: Cannot find coin record for clawback transaction 0x1b332cee62521ffe34d04712db291eeb3681e2453ff50811d65d0b87c9d470c3
2023-06-29T11:34:22.696 wallet chia.rpc.rpc_server        : WARNING  Error while handling message: Traceback (most recent call last):
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\rpc_server.py", line 340, in safe_handle
    response = await self.ws_api(message)
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\rpc_server.py", line 331, in ws_api
    return await f_rpc_api(data)
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\wallet_rpc_api.py", line 1062, in spend_clawback_coins
    coin_ids: List[bytes32] = [bytes32.from_hexstr(coin) for coin in request["coin_ids"]]
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\wallet_rpc_api.py", line 1062, in <listcomp>
    coin_ids: List[bytes32] = [bytes32.from_hexstr(coin) for coin in request["coin_ids"]]
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\util\byte_types.py", line 51, in from_hexstr
    if input_str.startswith("0x") or input_str.startswith("0X"):
AttributeError: 'NoneType' object has no attribute 'startswith'```

ytx1991 · 2023-06-29T19:55:17Z

Here's another issue I saw while attempting to claw back a transaction. Note that this problem might not be related to this PR:

nonetype.mp4
Log snippet:

Traceback (most recent call last):
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\wallet_rpc_api.py", line 912, in get_transactions
    assert record is not None, f"Cannot find coin record for clawback transaction {tx['name']}"
AssertionError: Cannot find coin record for clawback transaction 0x1b332cee62521ffe34d04712db291eeb3681e2453ff50811d65d0b87c9d470c3
2023-06-29T11:34:22.696 wallet chia.rpc.rpc_server        : WARNING  Error while handling message: Traceback (most recent call last):
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\rpc_server.py", line 340, in safe_handle
    response = await self.ws_api(message)
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\rpc_server.py", line 331, in ws_api
    return await f_rpc_api(data)
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\wallet_rpc_api.py", line 1062, in spend_clawback_coins
    coin_ids: List[bytes32] = [bytes32.from_hexstr(coin) for coin in request["coin_ids"]]
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\wallet_rpc_api.py", line 1062, in <listcomp>
    coin_ids: List[bytes32] = [bytes32.from_hexstr(coin) for coin in request["coin_ids"]]
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\util\byte_types.py", line 51, in from_hexstr
    if input_str.startswith("0x") or input_str.startswith("0X"):
AttributeError: 'NoneType' object has no attribute 'startswith'```

It seems like the clawback coin is missing for some reason. I assume it is related to wallet switching. For the auto claim, did you wait several minutes after the timelock expired?

danieljperry · 2023-06-30T13:38:31Z

Here's another issue I saw while attempting to claw back a transaction. Note that this problem might not be related to this PR:
nonetype.mp4
Log snippet:

Traceback (most recent call last):
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\wallet_rpc_api.py", line 912, in get_transactions
    assert record is not None, f"Cannot find coin record for clawback transaction {tx['name']}"
AssertionError: Cannot find coin record for clawback transaction 0x1b332cee62521ffe34d04712db291eeb3681e2453ff50811d65d0b87c9d470c3
2023-06-29T11:34:22.696 wallet chia.rpc.rpc_server        : WARNING  Error while handling message: Traceback (most recent call last):
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\rpc_server.py", line 340, in safe_handle
    response = await self.ws_api(message)
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\rpc_server.py", line 331, in ws_api
    return await f_rpc_api(data)
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\wallet_rpc_api.py", line 1062, in spend_clawback_coins
    coin_ids: List[bytes32] = [bytes32.from_hexstr(coin) for coin in request["coin_ids"]]
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\rpc\wallet_rpc_api.py", line 1062, in <listcomp>
    coin_ids: List[bytes32] = [bytes32.from_hexstr(coin) for coin in request["coin_ids"]]
  File "C:\Users\User\Chia\main+15496\chia-blockchain\chia\util\byte_types.py", line 51, in from_hexstr
    if input_str.startswith("0x") or input_str.startswith("0X"):
AttributeError: 'NoneType' object has no attribute 'startswith'```

It seems like the clawback coin is missing for some reason. I assume it is related to wallet switching. For the auto claim, did you wait several minutes after the timelock expired?

In this case for autoclaim, I switched to the receiver's wallet before the timelock expired. The autoclaim was then attempted in that wallet automatically as soon as the timelock expired.

github-actions · 2023-07-07T17:27:23Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2023-07-10T18:05:58Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

wjblanke

aok

Double check coin state

8a8f3f1

ytx1991 changed the base branch from main to release/1.8.2 June 13, 2023 05:21

ytx1991 changed the base branch from release/1.8.2 to main June 13, 2023 05:25

ytx1991 changed the base branch from main to release/1.8.2 June 13, 2023 05:25

xdustinface reviewed Jun 13, 2023

View reviewed changes

chia/wallet/wallet_state_manager.py Outdated Show resolved Hide resolved

ytx1991 marked this pull request as ready for review June 13, 2023 19:12

ytx1991 requested a review from a team as a code owner June 13, 2023 19:12

xdustinface closed this Jun 13, 2023

xdustinface reopened this Jun 13, 2023

Fix coverage

9a2ed50

ytx1991 added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jun 13, 2023

altendky previously requested changes Jun 14, 2023

View reviewed changes

chia/wallet/wallet_state_manager.py Outdated Show resolved Hide resolved

ytx1991 added 2 commits June 14, 2023 17:29

Resolve comments

2b56b2b

Fix unit test

ab4b6cd

altendky reviewed Jun 15, 2023

View reviewed changes

chia/wallet/wallet_state_manager.py Outdated Show resolved Hide resolved

ytx1991 closed this Jun 16, 2023

Fix redundant tx

810af8c

ytx1991 reopened this Jun 19, 2023

Add unit test

91ac933

wallentx closed this Jun 20, 2023

wallentx reopened this Jun 20, 2023

ytx1991 added 4 commits June 20, 2023 14:32

Fix unit test

8c51f8c

refine unit test

05b54c0

Remove duplicate test

bfa2df2

Fix test on Windows

374f10c

trepca requested review from altendky and xdustinface June 21, 2023 19:22

Resolve comments

01f0440

ytx1991 requested a review from xdustinface June 26, 2023 15:52

Revert clawback test fix

1ba1f2b

xdustinface reviewed Jun 26, 2023

View reviewed changes

chia/wallet/wallet_state_manager.py Show resolved Hide resolved

xdustinface reviewed Jun 26, 2023

View reviewed changes

chia/wallet/util/transaction_type.py Show resolved Hide resolved

Add comment for tx confirmed

e3faa45

wallentx changed the base branch from release/1.8.2 to main June 27, 2023 15:09

ytx1991 added 3 commits June 27, 2023 09:45

Resolve comments

c32d542

Merge branch 'main' into clawback_resync

5084117

Remove unrelated change

f010eb5

ytx1991 requested a review from xdustinface June 28, 2023 16:49

xdustinface suggested changes Jun 28, 2023

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

chia/wallet/wallet_state_manager.py Outdated Show resolved Hide resolved

tests/wallet/rpc/test_wallet_rpc.py Outdated Show resolved Hide resolved

Resolve comments

5bf6b9d

xdustinface previously approved these changes Jun 29, 2023

View reviewed changes

chia/wallet/wallet_state_manager.py Show resolved Hide resolved

danieljperry reviewed Jun 29, 2023

View reviewed changes

ytx1991 added the ready_to_merge Submitter and reviewers think this is ready label Jul 6, 2023

ytx1991 mentioned this pull request Jul 7, 2023

[Bug] clawback bugs overview version 1.8.2 #15703

Closed

github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 7, 2023

Merge branch 'main' into clawback_resync

6e6e524

ytx1991 dismissed xdustinface’s stale review via 6e6e524 July 10, 2023 18:05

github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 10, 2023

Fix coverage

4ed1ef7

wjblanke approved these changes Jul 11, 2023

View reviewed changes

wallentx merged commit 40a347f into main Jul 11, 2023
203 checks passed

wallentx deleted the clawback_resync branch July 11, 2023 18:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clawback resync #15496

Clawback resync #15496

ytx1991 commented Jun 13, 2023

xdustinface commented Jun 13, 2023

ytx1991 commented Jun 16, 2023

xdustinface commented Jun 20, 2023

xdustinface left a comment

danieljperry left a comment

danieljperry commented Jun 29, 2023

ytx1991 commented Jun 29, 2023

danieljperry commented Jun 30, 2023

github-actions bot commented Jul 7, 2023

github-actions bot commented Jul 10, 2023

wjblanke left a comment

Clawback resync #15496

Clawback resync #15496

Conversation

ytx1991 commented Jun 13, 2023

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

xdustinface commented Jun 13, 2023

ytx1991 commented Jun 16, 2023

xdustinface commented Jun 20, 2023

xdustinface left a comment

Choose a reason for hiding this comment

danieljperry left a comment

Choose a reason for hiding this comment

danieljperry commented Jun 29, 2023

ytx1991 commented Jun 29, 2023

danieljperry commented Jun 30, 2023

github-actions bot commented Jul 7, 2023

github-actions bot commented Jul 10, 2023

wjblanke left a comment

Choose a reason for hiding this comment