Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: include puzzles packages #15508

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

bbjubjub2494
Copy link
Contributor

@bbjubjub2494 bbjubjub2494 commented Jun 14, 2023

Purpose:

Fix #15507

Current Behavior:

New Behavior:

Testing Notes:

$ pip install git+https://github.com/lourkeur/chia-blockchain@fix_15507
$ python3
>>> import chia.wallet.puzzlest.clawback
>>> import chia.wallet.puzzles.prefarm
>>> 

@bbjubjub2494 bbjubjub2494 requested a review from a team as a code owner June 14, 2023 08:24
@paninaro paninaro requested a review from altendky June 14, 2023 15:51
@paninaro
Copy link
Contributor

@altendky can you take a look at this change?

@altendky altendky added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Cleanup Code cleanup labels Jun 14, 2023
Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For how we do it now, this looks proper. Thanks @lourkeur for catching it and helping us out!

At some point we should stop maintaining this list and consider #15180. I'll also note that there is a second layer in pyinstaller that was similar to this that I made more inclusive in https://github.com/Chia-Network/chia-blockchain/pull/15340/files.

@altendky altendky requested a review from paninaro June 14, 2023 17:26
@bbjubjub2494
Copy link
Contributor Author

You're welcome! You're right: this is typically something that should be automated and it looks like #15180 might have found the magic sequence of bytes that does what we want.

@wallentx wallentx merged commit 5d43f12 into Chia-Network:main Jun 14, 2023
200 of 201 checks passed
altendky pushed a commit that referenced this pull request Jun 29, 2023
(cherry picked from commit 5d43f12)
wallentx pushed a commit that referenced this pull request Jun 29, 2023
(cherry picked from commit 5d43f12)

Co-authored-by: Louis Bettens <lourkeur@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code cleanup Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Module chia.wallet.puzzles.clawback not found
4 participants