Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update build script for lerna 7 #15672

Merged
merged 1 commit into from
Jul 5, 2023
Merged

update build script for lerna 7 #15672

merged 1 commit into from
Jul 5, 2023

Conversation

paninaro
Copy link
Contributor

@paninaro paninaro commented Jul 1, 2023 •
edited
Loading

Purpose:

Update Windows build script to use lerna 7.0.0 and avoid pruning packages that are no longer where they used to be located.

Current Behavior:

Sad build, many breaks

New Behavior:

Happy build

Testing Notes:

Tested Windows build from CI

@paninaro paninaro added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jul 1, 2023
@wallentx wallentx self-requested a review July 1, 2023 01:39
@paninaro paninaro marked this pull request as ready for review July 1, 2023 02:28
@paninaro paninaro requested a review from a team as a code owner July 1, 2023 02:28
@wallentx
Copy link
Contributor

wallentx commented Jul 2, 2023

This is required in order for #15644 to pass

@wallentx wallentx requested a review from emlowe July 2, 2023 21:09
@paninaro paninaro requested a review from wjblanke July 5, 2023 20:14
wjblanke
wjblanke approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@wallentx wallentx merged commit e5ea486 into main Jul 5, 2023
203 of 204 checks passed
@wallentx wallentx deleted the paninaro.windows_update_build_script branch July 5, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

@wallentx wallentx wallentx approved these changes

@emlowe emlowe Awaiting requested review from emlowe

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paninaro @wallentx @wjblanke