Fix DID resync #15675
Fix DID resync #15675
Conversation
ytx1991
added
the
Fixed
There was a problem hiding this comment.
There is a print which should be dropped. And do you understand why this even happens during a sync because actually the coin states should be sorted so that unspent coin states come before spent ones? I know there are cases where we due to batching/task processing of the coin states might still process them out of order but here this should probably not be this case.. ? After quick check this feels like this might become flaky because you not really force the coin states to be out of order in the added test.
|
I have added a check while fixing Clawback resync. It will log something if the coin state in add_coin_states is unspent but in the latest block the coin state is spent. I resynced several times but never see that log printed so I assume during the resync, the wallet will not receive an unspent coin state for a spent coin. I thought there should be two coin states for a spent coin, but seems like it only has one coin state. |
There was a problem hiding this comment.
so I assume during the resync, the wallet will not receive an unspent coin state for a spent coin.
Okay yeah thats right. I digged more into this and its indeed because we alter the states in the full node and of course then only send the spent states after.
I think it would be good to add the the proposed renaming for the test, it makes it easier to read/understand it.
Thinking about this test maybe you should just resync both wallets and also assert at the end that the DID wallets (not) exists for the particular wallet instead of only checking the tx record and unspent coin count?
I also think, now you only test the resync after the coin was spent but not if the coin is still unspent. Do you think we should test all cases?
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Purpose:
During the resync, it may create DID wallets that don't belong to the current key. These wallets will not be removed after fully synced. It confuses users.
Current Behavior:
New Behavior:
Only create DID wallet when we see the DID coin the first time, and it is unspent.
Testing Notes: