Remove references to old offer mod #15694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
Quexington
force-pushed
the
quex.remove_old_offer_format
branch
from
b0a9765
to
9cb8c64
Compare
geoffwalmsley
previously approved these changes
Jul 13, 2023
github-actions
bot
added
the
merge_conflict
github-actions
bot
removed
the
merge_conflict
trepca
reviewed
Jul 17, 2023
trepca
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously deprecated the original offer mod in favor of a new one that checks create coin amounts. However, we left in some forwards compatibility code so that new clients could still take old offers, they would just never make any new ones. This PR deletes that code as it's been enough time to fully drop support for the old offers.
The only remaining evidence that the original existed is in the puzzle compression dictionary and in some temporary warnings to have a graceful error if someone attempts to take an old style offer.