Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compressed plot support #15702

Merged
merged 2 commits into from
Jul 12, 2023
Merged

compressed plot support #15702

merged 2 commits into from
Jul 12, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jul 6, 2023

bumps the chiapos dependency and adds support for compressed plots to:

  1. the harvester
  2. chia plots check
  3. plot manager

@arvidn arvidn requested a review from a team as a code owner July 6, 2023 22:18
@arvidn arvidn marked this pull request as draft July 6, 2023 22:18
@arvidn arvidn requested a review from fchirica July 6, 2023 22:18
@arvidn arvidn added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Jul 7, 2023
@arvidn arvidn closed this Jul 7, 2023
@arvidn arvidn reopened this Jul 7, 2023
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jul 10, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jul 10, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@arvidn arvidn marked this pull request as ready for review July 10, 2023 20:16
@arvidn arvidn force-pushed the compression branch 2 times, most recently from 9d8a72f to ffcf972 Compare July 11, 2023 18:39
@arvidn arvidn requested a review from AmineKhaldi July 11, 2023 19:10
@arvidn arvidn requested a review from wjblanke July 11, 2023 19:29
@arvidn
Copy link
Contributor Author

arvidn commented Jul 12, 2023

I think it could make sense to declare the lack of test coverage OK, since we're doing extensive manual testing of this. Also since we don't have CI runners that can run plot decompression at all, it makes it a bit trickier

wjblanke
wjblanke approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@wallentx wallentx mentioned this pull request Jul 12, 2023
Closed
@wallentx wallentx merged commit 7b67fe0 into main Jul 12, 2023
203 of 204 checks passed
@wallentx wallentx deleted the compression branch July 12, 2023 21:49
@wallentx wallentx mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmineKhaldi AmineKhaldi AmineKhaldi approved these changes

@wjblanke wjblanke wjblanke approved these changes

@fchirica fchirica Awaiting requested review from fchirica

Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arvidn @AmineKhaldi @wjblanke @wallentx @fchirica