Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump chia_rs dependency to 0.2.9 #15760

Merged
merged 1 commit into from
Jul 14, 2023
Merged

bump chia_rs dependency to 0.2.9 #15760

merged 1 commit into from
Jul 14, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Jul 13, 2023

this is blocked on chia_rs 0.2.9 being released.

This just bumps the dependency and updates the Spend constructor calls in tests. In production the Spend objects are all created on the rust side.

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jul 13, 2023
arvidn
arvidn commented Jul 13, 2023
View reviewed changes
setup.py Show resolved Hide resolved
@arvidn arvidn requested a review from AmineKhaldi July 13, 2023 19:30
@arvidn arvidn marked this pull request as ready for review July 13, 2023 19:37
@arvidn arvidn requested a review from a team as a code owner July 13, 2023 19:37
@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 5547131900

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • 85 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.1%) to 87.368%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 77.13%
chia/timelord/timelord.py 1 73.53%
chia/wallet/wallet_state_manager.py 3 95.23%
chia/wallet/wallet_node.py 7 86.2%
chia/data_layer/data_store.py 10 91.64%
chia/data_layer/download_data.py 12 54.94%
chia/data_layer/data_layer.py 51 63.21%
Totals Coverage Status
Change from base Build 5546768213: -0.1%
Covered Lines: 80181
Relevant Lines: 91649
💛 - Coveralls

@jack60612 jack60612 self-requested a review July 14, 2023 00:28
jack60612
jack60612 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@jack60612 jack60612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit messy but looks good.

tests/core/mempool/test_mempool_manager.py Show resolved Hide resolved
tests/generator/test_rom.py Show resolved Hide resolved
@arvidn arvidn requested a review from wjblanke July 14, 2023 00:44
wjblanke
wjblanke approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Jul 14, 2023
@wallentx wallentx merged commit 8491663 into main Jul 14, 2023
205 checks passed
@wallentx wallentx deleted the bump-chia-rs-0.2.9 branch July 14, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

@jack60612 jack60612 jack60612 approved these changes

@AmineKhaldi AmineKhaldi Awaiting requested review from AmineKhaldi

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arvidn @wjblanke @jack60612 @wallentx