Fix Cli error when exiting on some builds of python. #15762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack60612
added
the
Fixed
jack60612
force-pushed
the
jn.fix-sneaky-python-bug
branch
from
5f96e97
to
77c1f5e
Compare
jack60612
changed the title
arvidn
previously approved these changes
Jul 14, 2023
arvidn
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
originally made sure the catch runs sys.exit not exit() which is not in some builds of python.
It also changed the error to a click exception to remove the need for the handling at all.
Current Behavior:
Changes to use click errors instead of std errors.
New Behavior:
N/A
Testing Notes:
Kinda hard to replicate, but this is a fix