-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chip13 (#15688) #15825
Merged
Merged
Chip13 (#15688) #15825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Chip13 * Lint. * Black. * Lint. * Fix BlockTools. * Trigger the soft fork. * Parametrize bt. * Syntax. * Add softfork3 to empty_blockchain too. * Skip test. * Skip test. * Try fix. * Add persistent blocks. * Lint. * Run tests without block cache. * Try to fix tests. * Revert "Try to fix tests." This reverts commit f10c7fc. * WIP plot filters. * pytest. * Lint. * Skip cache tests. * Try to lower the constraints. * Try to increase timeout. * Test blockchain. * Store test. * Revert to main * Revert to main * Revert to main * Add tests with new interface * Test. * Fixtures. * Fixtures. * Lint. * Add first test. * Improve test. * Isort. * merge fix * fix counter * Bump test-cache version to soft_fork3.0 DBs * Enable tests. * Enable all. * Syntax. * Attempt higher timeouts. * Try to skip big test. * Revert tests larger timeouts. * Try to get test to work with 4000. * Skip 10000 blocks. * Test. * Update test_full_node_store.py * Update test_blockchain.py * Update test_blockchain.py * Update tests/conftest.py Co-authored-by: Arvid Norberg <arvid@libtorrent.org> * Update tests/blockchain/test_blockchain.py Co-authored-by: Arvid Norberg <arvid@libtorrent.org> * Address some comments. * Some more comments. * Use new passes_plot_filter signature. * Lint. * Lint. * Reduce benchmark timeout. * Skip test. * Address review comments. * Delete leftovers. * Review comments. * await. * Revert async call. * Validate in body too. * Fix test. --------- Co-authored-by: almog <almogdepaz@gmail.com> Co-authored-by: wallentx <william.allentx@gmail.com> Co-authored-by: Arvid Norberg <arvid@libtorrent.org>
wjblanke
previously approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aok
wjblanke
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chip13
Lint.
Black.
Lint.
Fix BlockTools.
Trigger the soft fork.
Parametrize bt.
Syntax.
Add softfork3 to empty_blockchain too.
Skip test.
Skip test.
Try fix.
Add persistent blocks.
Lint.
Run tests without block cache.
Try to fix tests.
Revert "Try to fix tests."
This reverts commit f10c7fc.
WIP plot filters.
pytest.
Lint.
Skip cache tests.
Try to lower the constraints.
Try to increase timeout.
Test blockchain.
Store test.
Revert to main
Revert to main
Revert to main
Add tests with new interface
Test.
Fixtures.
Fixtures.
Lint.
Add first test.
Improve test.
Isort.
merge fix
fix counter
Bump test-cache version to soft_fork3.0 DBs
Enable tests.
Enable all.
Syntax.
Attempt higher timeouts.
Try to skip big test.
Revert tests larger timeouts.
Try to get test to work with 4000.
Skip 10000 blocks.
Test.
Update test_full_node_store.py
Update test_blockchain.py
Update test_blockchain.py
Update tests/conftest.py
Update tests/blockchain/test_blockchain.py
Address some comments.
Some more comments.
Use new passes_plot_filter signature.
Lint.
Lint.
Reduce benchmark timeout.
Skip test.
Address review comments.
Delete leftovers.
Review comments.
await.
Revert async call.
Validate in body too.
Fix test.
Purpose:
Current Behavior:
New Behavior:
Testing Notes: