Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add condition opcodes for agg sigs to condition_codes.clib #15889

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Add condition opcodes for agg sigs to condition_codes.clib #15889

merged 3 commits into from
Aug 3, 2023

Conversation

Quexington
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@Quexington Quexington marked this pull request as ready for review July 28, 2023 18:04
@Quexington Quexington requested a review from a team as a code owner July 28, 2023 18:04
@Quexington Quexington requested a review from arvidn July 28, 2023 18:04
arvidn
arvidn previously approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test!
since these conditions won't be available until after the hard-fork, it might make sense to make a comment about that. it's a year out after all

@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jul 28, 2023
@Quexington Quexington closed this Aug 2, 2023
@Quexington Quexington reopened this Aug 2, 2023
@wallentx wallentx merged commit fe9b4aa into main Aug 3, 2023
381 of 385 checks passed
@wallentx wallentx deleted the quex.add_missing_opcodes branch August 3, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Quexington @arvidn @wallentx