Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed chia plotnft show command #15918

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Fixed chia plotnft show command #15918

merged 1 commit into from
Aug 3, 2023

Conversation

ChiaMineJP
Copy link
Contributor

Fixed an issue where chia plotnft show command showed nothing if -i/--id option is not provided.
I believe that chia plotnft show changes introduced by this PR(#15704 ) is not fully expected so my PR is reverting behavior before the #15704 was merged.

@ChiaMineJP ChiaMineJP added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Aug 2, 2023
@ChiaMineJP ChiaMineJP self-assigned this Aug 2, 2023
@ChiaMineJP ChiaMineJP requested a review from a team as a code owner August 2, 2023 16:38
arvidn
arvidn previously approved these changes Aug 2, 2023
View reviewed changes
jack60612
jack60612 requested changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@jack60612 jack60612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this merge / revert got messed up

chia/cmds/plotnft_funcs.py Show resolved Hide resolved
@jack60612 jack60612 self-requested a review August 3, 2023 03:11
jack60612
jack60612 previously approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@jack60612 jack60612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, last review sucked because i was on mobile.

@ChiaMineJP ChiaMineJP dismissed stale reviews from jack60612 and arvidn via 052777b August 3, 2023 03:45
jack60612
jack60612 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@jack60612 jack60612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i cant see any new changes except the catch up with main

@ChiaMineJP
Copy link
Contributor Author

@arvidn @jack60612
Sorry I accidentally added commits which should belong to another PR.
I ran git reset HEAD^ to dismiss the wrong commit and force-pushed the original commit-history which doesn't include the wrong commit.
The state of this PR is the same to the one both of you reviewed and approved.
Sorry for letting you review the same code twice!

@jack60612
Copy link
Contributor

@arvidn @jack60612 Sorry I accidentally added commits which should belong to another PR. I ran git reset HEAD^ to dismiss the wrong commit and force-pushed the original commit-history which doesn't include the wrong commit. The state of this PR is the same to the one both of you reviewed and approved. Sorry for letting you review the same code twice!

all good, approved.

@wallentx wallentx merged commit d13538d into release/2.0.0 Aug 3, 2023
951 of 953 checks passed
@wallentx wallentx deleted the cmj.fix-plotnft-show-cmd branch August 3, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paninaro paninaro paninaro approved these changes

@jack60612 jack60612 jack60612 approved these changes

@arvidn arvidn Awaiting requested review from arvidn

Assignees

@ChiaMineJP ChiaMineJP

Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ChiaMineJP @jack60612 @paninaro @arvidn @wallentx