-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nft_wallet.py #15968
Merged
Merged
Update nft_wallet.py #15968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issue reuse_puzhash for new NFT
@YeungTing Thank you for the fix. Can you update your PR description to include the following info? Purpose:
Current Behavior:
New Behavior:
Testing Notes:
|
paninaro
requested changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the description to include the requested info
Updated, please check |
Looks good to me |
paninaro
approved these changes
Aug 8, 2023
paninaro
added
Fixed
Required label for PR that categorizes merge commit message as "Fixed" for changelog
ready_to_merge
Submitter and reviewers think this is ready
labels
Aug 8, 2023
Pull Request Test Coverage Report for Build 5797903225
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Fixed
Required label for PR that categorizes merge commit message as "Fixed" for changelog
ready_to_merge
Submitter and reviewers think this is ready
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue reuse_puzhash for mint NFT
Purpose:
Reuse_puzhash parameter of mint nft cli /rpc allow us the reuse xch address instead of generative new address
Current Behavior:
Even have --reuse in the cli parameter, still generate new address
New Behavior:
Will reuse address if you have --reuse
Testing Notes:
Tested in mainnet