Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nft_wallet.py #15968

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Update nft_wallet.py #15968

merged 1 commit into from
Aug 9, 2023

Conversation

YeungTing
Copy link
Contributor

@YeungTing YeungTing commented Aug 8, 2023

Fixed issue reuse_puzhash for mint NFT
Purpose:
Reuse_puzhash parameter of mint nft cli /rpc allow us the reuse xch address instead of generative new address

Current Behavior:
Even have --reuse in the cli parameter, still generate new address

New Behavior:
Will reuse address if you have --reuse

Testing Notes:
Tested in mainnet

fix issue reuse_puzhash for new NFT
@YeungTing YeungTing requested a review from a team as a code owner August 8, 2023 13:58
@paninaro
Copy link
Contributor

paninaro commented Aug 8, 2023

@YeungTing Thank you for the fix. Can you update your PR description to include the following info?

Purpose:

  • Explain why this is an improvement (Does this add missing functionality, improve performance, or reduce complexity?)
  • Does this PR introduce a breaking change?

Current Behavior:

  • How does the code behave before applying this set of changes?

New Behavior:

  • What is the new behavior after applying this set of changes?

Testing Notes:

  • As we aim for complete code coverage, please include details regarding unit, and regression tests

Copy link
Contributor

@paninaro paninaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description to include the requested info

@YeungTing
Copy link
Contributor Author

Updated, please check

@YeungTing YeungTing requested a review from paninaro August 8, 2023 16:32
@ytx1991
Copy link
Contributor

ytx1991 commented Aug 8, 2023

Looks good to me

@paninaro paninaro added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog ready_to_merge Submitter and reviewers think this is ready labels Aug 8, 2023
@coveralls-official
Copy link

coveralls-official bot commented Aug 8, 2023

Pull Request Test Coverage Report for Build 5797903225

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.002%) to 87.864%

Files with Coverage Reduction New Missed Lines %
chia/wallet/wallet_state_manager.py 1 95.77%
tests/core/util/test_lockfile.py 1 90.78%
chia/server/server.py 2 74.62%
chia/wallet/wallet_node.py 6 86.48%
Totals Coverage Status
Change from base Build 5794013540: 0.002%
Covered Lines: 82348
Relevant Lines: 93626

💛 - Coveralls

@wallentx wallentx closed this Aug 9, 2023
@wallentx wallentx reopened this Aug 9, 2023
@wallentx wallentx merged commit 3cc5ef8 into Chia-Network:main Aug 9, 2023
385 of 386 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants