Fix timelord-install.sh for CentOS\RHEL #15992
Conversation
Starttoaster
added
the
Fixed
|
Hi @LeroyINC sorry for the late call out on this. I just noticed because of the CI workflow that there are unsigned commits in this PR. Unfortunately, commit signatures are required for contributions, which can be seen in the contributing.md file/policy here https://github.com/Chia-Network/chia-blockchain/blob/main/CONTRIBUTING.md#creating-signed-commits If it's not too much effort, could you please sign them? If you're not able to set that up, I could make this contribution on your behalf, which I'd prefer not to do, simply to give you credit for your work. But if you're happy just seeing the change merged in, I could definitely do that for you. |
|
I will see if I can sign this.. not sure how, since it has some other commits\edits after the unsigned commit. |
|
If git isn't working with you, feel free to close the PR and make a new one from a new branch with your commit signed and just link it to me in here and we can go from there. :) |
LeroyINC
force-pushed
the
fix-install-timelord.sh
branch
from
ce5cc2c
to
850fb28
Compare
Signed-off-by: LeroyINC <leroy@integrated.net>
Changed command structure to be more compatible with different flavors of Linux
updated as requested.
LeroyINC
force-pushed
the
fix-install-timelord.sh
branch
from
0272e3a
to
7f07148
Compare
|
ok i have signed my commits... |
Purpose:
This pull request fixes the issue were the install-timelord.sh fails on CentOS and RHEL
Current Behavior:
When running the install-timelord.sh on CentOS\RHEL the install fails because the name of the python development package that the script tries to install is wrong. For CentOS\RHEL the name is "python3-devel"
If you chose to not to install the python3 development package using the "-n" option --> "install-timelord.sh -n"
This causes the yum command to have a double space in the command and then yum throws an error and the script aborts.
New Behavior:
The package name is updated only for CentOS/RHEL, the Package name for other OSes is not changed. The double space issues in the yum command has been fixed.
This results in the expected behavior.
Testing Notes:
tested by running install-timelord.sh on CentOS 9 system with and without the -n switch