Use 'Completed writing plot' as the magic final words for cudaplot #16011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlowe
added
the
Changed
wallentx
approved these changes
Aug 10, 2023
harold-b
approved these changes
Aug 10, 2023
paninaro
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GUI plotting with
cudaplotcreates the plot, but it is stuck at 98% as the magic words expected in the log file are not present.BB
cudaplotis not using the final words expected to trigger the daemon and GUI to consider the plot complete.Adjusted to use the
Completed writing plotmagic words as the final words. Previously this was used as the 98% trigger, which is where the GUI would get stuck.Tested locally. There are some related tests that likely need to be expanded, and this could use a refactor, but this is a minimal change for 2.0.0