Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a full node RPC endpoint, get_mempool_items_by_coin_name #16019

Merged

Conversation

kimsk
Copy link
Contributor

@kimsk kimsk commented Aug 12, 2023

Purpose:

New PR to replace #15625 to implement an endpoint to get mempool items by a coin name mentioned in #14810.

Testing Notes:

pre-commit

image

pytest

tests/core/test_full_node_rpc/test_coin_name_not_in_request
tests/core/test_full_node_rpc/test_coin_name_not_found_in_mempool
tests/core/test_full_node_rpc/test_coin_name_found_in_mempool
image

manual

image image

@kimsk kimsk requested a review from a team as a code owner August 12, 2023 04:28
@kimsk kimsk changed the title get_mempool_items_by_coin_name Add a full node RPC endpoint, get_mempool_items_by_coin_name Aug 12, 2023
@wallentx wallentx added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 14, 2023
@emlowe emlowe requested a review from arvidn August 14, 2023 16:05
@wallentx wallentx requested a review from emlowe August 23, 2023 09:24
Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to expose this.

@emlowe emlowe added Added Required label for PR that categorizes merge commit message as "Added" for changelog and removed Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Aug 31, 2023
@wallentx wallentx merged commit 0a67194 into Chia-Network:main Aug 31, 2023
202 checks passed
@kimsk kimsk deleted the karlkim.get_mempool_items_by_coin_name branch September 8, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants