Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout for retrieving a decompressor. #16047

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Timeout for retrieving a decompressor. #16047

merged 4 commits into from
Aug 16, 2023

Conversation

fchirica
Copy link
Contributor

If no decompressor is available within decompressor_timeout seconds, we abort the operation.

@fchirica fchirica requested a review from a team as a code owner August 15, 2023 16:30
@fchirica fchirica added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Aug 15, 2023
emlowe
emlowe previously approved these changes Aug 15, 2023
View reviewed changes
wallentx
wallentx previously requested changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@wallentx wallentx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several CLI commands are broken, and it seems the macos chiapos wheels are somehow invalid?

@altendky
Copy link
Contributor

The wheel check was run on macOS 10.14 seemingly.

https://github.com/Chia-Network/chia-blockchain/actions/runs/5871107557/job/15921053154?pr=16047#step:5:15

platform: macOS-10.14.6-x86_64-i386-64bit

https://github.com/Chia-Network/chia-blockchain/actions/runs/5871107557/job/15921053154?pr=16047#step:1:2

Runner name: 'macpro-01-mojave-01-msp'

But... we ask for 11.

chia-blockchain/.github/workflows/check_wheel_availability.yaml

Line 36 in 7b9801f

intel: macos-11

They still list macos-11 as valid here at least. https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

@altendky
Copy link
Contributor

Nevermind, https://github.com/Chia-Network/chia-blockchain/actions/runs/5871107557/workflow?pr=16047#L36 that build actually asked for macos-10.14 specifically...

@altendky
Copy link
Contributor

29c1e1c is on main and not on release/2.0.0. So either we go back to building 10.14 wheels for now or we get the 10.14 drop updates into release.

@altendky altendky mentioned this pull request Aug 16, 2023
Merged
@wallentx wallentx dismissed their stale review August 16, 2023 14:18

The problems were on my end

@cmmarslender
Copy link
Contributor

29c1e1c is on main and not on release/2.0.0. So either we go back to building 10.14 wheels for now or we get the 10.14 drop updates into release.

As of now, 2.0.0 is supposed to be the last release to support 10.14

wallentx pushed a commit to Chia-Network/chiapos that referenced this pull request Aug 16, 2023
@altendky @emlowe
build wheels for macOS 10.14 for now (#383)
08b7b95 
Chia-Network/chia-blockchain#16047 (review)

Co-authored-by: Earle Lowe <e.lowe@chia.net>
@wallentx wallentx merged commit 0deb8e6 into release/2.0.0 Aug 16, 2023
480 of 481 checks passed
@wallentx wallentx deleted the fc.timeout_decompressor2.0 branch August 16, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

@wallentx wallentx wallentx left review comments

Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fchirica @altendky @cmmarslender @wallentx @emlowe