Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete DL files on unsubscribe. #16182

Merged
merged 15 commits into from
Sep 6, 2023
Merged

Delete DL files on unsubscribe. #16182

merged 15 commits into from
Sep 6, 2023

Conversation

fchirica
Copy link
Contributor

Removes both locally stored full files and delta files when we unsubscribe to a delta layer store.

@fchirica fchirica requested a review from a team as a code owner August 28, 2023 16:49
@fchirica fchirica added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Aug 28, 2023
altendky
altendky requested changes Aug 29, 2023
View reviewed changes
chia/data_layer/data_layer.py Outdated Show resolved Hide resolved
tests/core/data_layer/test_data_rpc.py Outdated Show resolved Hide resolved
tests/core/data_layer/test_data_rpc.py Outdated Show resolved Hide resolved
tests/core/data_layer/test_data_rpc.py Outdated Show resolved Hide resolved
tests/core/data_layer/test_data_rpc.py Outdated Show resolved Hide resolved
tests/core/data_layer/test_data_rpc.py Outdated Show resolved Hide resolved
fchirica and others added 5 commits August 29, 2023 18:19
@fchirica @altendky
Update chia/data_layer/data_layer.py
56f5f5b 
Co-authored-by: Kyle Altendorf <sda@fstab.net>
@fchirica @altendky
Apply suggestions from code review
289f44c 
Co-authored-by: Kyle Altendorf <sda@fstab.net>
@fchirica
rewiew comments.
ce8ba3a
@fchirica
review
d782c1b
@fchirica
Update test_data_rpc.py
870ae31
altendky
altendky previously approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

altendky
altendky previously approved these changes Aug 30, 2023
View reviewed changes
emlowe
emlowe previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - well add separate issue to create a retain option

@emlowe emlowe mentioned this pull request Aug 30, 2023
Closed
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Aug 30, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@fchirica fchirica dismissed stale reviews from emlowe and altendky via f63dee7 September 5, 2023 16:55
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@emlowe emlowe linked an issue Sep 6, 2023 that may be closed by this pull request
Add option on unsubscribe to retain DAT files #16197
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

File Coverage Missing Lines
chia/cmds/data.py 50.0% lines 265
chia/cmds/data_funcs.py 0.0% lines 137
chia/data_layer/data_layer.py 87.5% lines 563-564
chia/rpc/data_layer_rpc_client.py 50.0% lines 74
Total Missing Coverage
57 lines 5 lines 91%

@emlowe
Copy link
Contributor

emlowe commented Sep 6, 2023

Coverage diff exception approved

@wallentx wallentx merged commit 8cc32ed into main Sep 6, 2023
209 of 210 checks passed
@wallentx wallentx deleted the fc.cleanup_dl_unsub branch September 6, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

@altendky altendky altendky left review comments

Assignees
No one assigned
Labels
DataLayer Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option on unsubscribe to retain DAT files
4 participants
@fchirica @emlowe @altendky @wallentx