Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition serialization in RPC client #16389

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

Quexington
Copy link
Contributor

This is a bug fix from some introduced code in #15911 which serialized the extra_conditions improperly in the wallet RPC client causing it to fail to parse in the API. This has been broken since it's introduction and this PR fixes it.

@Quexington Quexington requested a review from a team as a code owner September 21, 2023 16:45
@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Sep 21, 2023
Copy link
Contributor

@ytx1991 ytx1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@wallentx wallentx merged commit b89aa40 into main Sep 25, 2023
239 checks passed
@wallentx wallentx deleted the quex.fix_rpc_client_extra_conditions branch September 25, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants