[CHIA-307] (long-lived) Vault #16610

Quexington · 2023-10-12T20:39:48Z

Todo:

Get a proper review for: Wallet Signer Protocol #16883
Address the forwards compatibility of resetting sync DB on next restart ([CHIA-683] Drop unknown tables when resetting wallet sync DB #18222)
Double check that the private key is not still in the config :)

Source hash: e80ab1c Remaining commits: 0 Merge conflict resolutions: https://quexington.github.io/merge-diffs/29a01058f5b89aa07bd9c335d7b215e756e093c2.html

…3e3b630fbd507c607fe7' into quex.signer_protocol

…tation'

…ning_from_wallet

…vation_root

…tocol

…ort_layer

…ling) (#18065) This brings another set of commands to the @tx_out_cmd decorator which gives it the capability to optionally push a transaction and export the transactions to a local file. This PR being the last in a chain of similar PRs, I have included some comments explaining that DL and pooling endpoints will not be ported to the decorator at this time. Didn't think that necessitated its own PR and CI run :)

…long_lived_vault_from_main_32fd48159f761ad7c59e5b8f02a7aed17e2503e9

Source hash: 32fd481 Remaining commits: 0 Merge diffs: https://quexington.github.io/merge-diffs/5c407ea9bbab94ca2da71e786e8264f8197bfa08.html

This adds an RPC endpoint for the wallet to act as a signer for unsigned transactions generated by other wallets.

This PR introduces a new `TranslationLayer` concept to the `@clvm_streamable` library enabling reconstruction from CHIP-27 APIs into more specific responses for different types of clients. CHIP-28 is one such chip and support for it is enable as well.

This PR caps off a thread of work that supports external signers for transactions generated by the wallet. With these commands, it should be possible to run two wallets with different security qualities and transport transactions back and forth between them for the colder one to sign. It currently uses binary files/QR codes to accomplish this although other methods of transport are certainly on the table.

…long_lived_vault_from_main_9ea4609618cba2229dc9f4b916ec82927c79a0d6

…puzzle_w_aggregator

Source hash: 9ea4609 Remaining commits: 0 Merge-diffs: https://quexington.github.io/merge-diffs/13ccfa7a4758099c00943be6d4d1a59afa4c854b.html

The existing version of this was built somewhat specifically for DAOs. I've renamed that one and added this new one as a simplification/generalization.

…long_lived_vault_from_main_9e1a4dceb724d7ebf56e3d8a75e8692184997805

Source hash: 9e1a4dc Remaining commits: 0 Merge diffs: https://quexington.github.io/merge-diffs/844cb8ea94ce7f419c3d26ba471f747de021784f.html

Quexington added Added Required label for PR that categorizes merge commit message as "Added" for changelog vault labels Oct 12, 2023

Chia-Network deleted a comment from coveralls-official bot Oct 19, 2023

github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 30, 2023

Quexington and others added 26 commits January 5, 2024 09:56

catchup: into long_lived/vault from main @ e80ab1c (#17200)

09c2683

Source hash: e80ab1c Remaining commits: 0 Merge conflict resolutions: https://quexington.github.io/merge-diffs/29a01058f5b89aa07bd9c335d7b215e756e093c2.html

Merge branch 'long_lived/vault' into gw.vault_create_rpc

402fd66

fix test framework imports and use make_spend for CoinSpend

52ecbf2

Repin hsms

1e1610c

Endpoint for vault singleton creation (#17093)

7fc1d2a

Add to sdist only allowed list

39bab6d

Merge remote-tracking branch 'origin/main' into long_lived/vault

1fbe09d

Merge branch 'catchup/long_lived_vault_from_main_84f3e3d9f2f1e1a7a3db…

533935d

…3e3b630fbd507c607fe7' into quex.signer_protocol

Signer protocol tweaks

1e1d9a7

Merge branch 'quex.signer_protocol' into 'quex.wallet_signer_implemen…

e46225c

…tation'

Merge branch 'quex.wallet_signer_implementation' into quex.remove_sig…

1217e77

…ning_from_wallet

Merge branch 'quex.remove_signing_from_wallet' into quex.allow_only_pks

6c7699d

Merge branch 'quex.allow_only_pks' into quex.private_key_optional

3b6ef9b

Merge branch 'quex.private_key_optional' into quex.observer_mode

2cc1df3

Convert wallet RPC client to deserialized types

297115d

Merge branch 'quex.observer_mode' into quex.pubkey_to_observation_root

957b460

Merge branch 'quex.pubkey_to_observation_root' into quex.wallet_obser…

fc48267

…vation_root

Introduce @tx_out_cmd decorator

8a76ae9

Merge branch 'quex.wallet_observation_root' into quex.main_wallet_pro…

dff2cba

…tocol

Make execute_signing_instructions RPC

6ebde50

Merge branch 'quex.main_wallet_protocol' into quex.prep_for_vault_wallet

55e78e8

Add transport layer support

5e4286a

Add signer commands

6dafcd0

Rework wallet execute_signing_instructions

f8d034d

Inadvertent merge changes

bea085d

Merge branch 'quex.observer_mode' into quex.wallet_rpc_client_types

3574f09

Quexington added 6 commits May 23, 2024 09:00

Merge branch 'quex.execute_signing_instructions_rpc' into quex.transp…

8b7d391

…ort_layer

Fix rpc util

a12341b

Merge branch 'quex.transport_layer' into quex.signer_commands

205045c

Merge commit '32fd48159f761ad7c59e5b8f02a7aed17e2503e9' into catchup/…

5c407ea

…long_lived_vault_from_main_32fd48159f761ad7c59e5b8f02a7aed17e2503e9

catchup: long_lived/vault from main @ 32fd481 (#18071)

6fbee4d

Source hash: 32fd481 Remaining commits: 0 Merge diffs: https://quexington.github.io/merge-diffs/5c407ea9bbab94ca2da71e786e8264f8197bfa08.html

github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 28, 2024

Chia-Network deleted a comment from github-actions bot May 28, 2024

github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 29, 2024

Chia-Network deleted a comment from github-actions bot May 29, 2024

Quexington and others added 16 commits June 3, 2024 14:30

[CHIA-433] Make execute_signing_instructions RPC (#17398)

78c8fb7

This adds an RPC endpoint for the wallet to act as a signer for unsigned transactions generated by other wallets.

add test for BSTLSigningInstructions

95ac9f1

Merge commit '9ea4609618cba2229dc9f4b916ec82927c79a0d6' into catchup/…

13ccfa7

…long_lived_vault_from_main_9ea4609618cba2229dc9f4b916ec82927c79a0d6

Rename p2_singeton_via_delegated_puzzle -> p2_singeton_via_delegated_…

f370c45

…puzzle_w_aggregator

catchup: long_lived/vault from main @ 9ea4609 (#18144)

4091d79

Source hash: 9ea4609 Remaining commits: 0 Merge-diffs: https://quexington.github.io/merge-diffs/13ccfa7a4758099c00943be6d4d1a59afa4c854b.html

Add Add p2_singleton_via_delegated_puzzle_safe.clsp

d9c30a2

Add test coverage

0c993a0

test coverage again

62e73a0

move gather_signing_info to main wallet

5c7364d

[CHIA-777] Generalize p2_singleton_via_delegated_puzzle (#18197)

e583831

The existing version of this was built somewhat specifically for DAOs. I've renamed that one and added this new one as a simplification/generalization.

Merge commit '9e1a4dceb724d7ebf56e3d8a75e8692184997805' into catchup/…

17e52c5

…long_lived_vault_from_main_9e1a4dceb724d7ebf56e3d8a75e8692184997805

Bring Wallet into conformity with MainWalletProtocol

844cb8e

catchup: long_lived/vault from main @ 9e1a4dc (#18258)

57198e2

Source hash: 9e1a4dc Remaining commits: 0 Merge diffs: https://quexington.github.io/merge-diffs/844cb8ea94ce7f419c3d26ba471f747de021784f.html

move gather_signing_info to main wallet (#18240)

6f55be0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CHIA-307] (long-lived) Vault #16610

[CHIA-307] (long-lived) Vault #16610

Quexington commented Oct 12, 2023 •

edited

Loading

[CHIA-307] (long-lived) Vault #16610

Are you sure you want to change the base?

[CHIA-307] (long-lived) Vault #16610

Conversation

Quexington commented Oct 12, 2023 • edited Loading

Quexington commented Oct 12, 2023 •

edited

Loading