Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedupe parent_amount_list #16724

Merged
merged 9 commits into from
Nov 29, 2023
Merged

Conversation

geoffwalmsley
Copy link
Contributor

Deduplicate parent_amount_list for each CAT asset in dao_spend_p2_singleton

@geoffwalmsley geoffwalmsley added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Oct 28, 2023
@geoffwalmsley geoffwalmsley marked this pull request as ready for review October 31, 2023 18:02
@geoffwalmsley geoffwalmsley requested a review from a team as a code owner October 31, 2023 18:02
Copy link

coveralls-official bot commented Nov 3, 2023

Pull Request Test Coverage Report for Build 6991860445

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 205 of 205 (100.0%) changed or added relevant lines in 3 files are covered.
  • 940 unchanged lines in 33 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.246%

Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 77.41%
chia/full_node/mempool_check_conditions.py 1 98.05%
chia/util/generator_tools.py 1 98.04%
chia/util/merkle_set.py 1 88.43%
tests/simulation/test_simulation.py 1 96.52%
chia/wallet/wallet_singleton_store.py 2 98.64%
chia/consensus/constants.py 3 94.03%
chia/server/node_discovery.py 3 79.55%
chia/server/server.py 3 79.66%
tests/core/full_node/stores/test_full_node_store.py 3 99.34%
Totals Coverage Status
Change from base Build 6936762432: -0.02%
Covered Lines: 93390
Relevant Lines: 103426

💛 - Coveralls

matt-o-how
matt-o-how previously approved these changes Nov 6, 2023
matt-o-how
matt-o-how previously approved these changes Nov 27, 2023
@geoffwalmsley geoffwalmsley changed the base branch from main to release/2.1.2 November 27, 2023 22:29
@geoffwalmsley geoffwalmsley dismissed matt-o-how’s stale review November 27, 2023 22:29

The base branch was changed.

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok!

@cmmarslender cmmarslender merged commit 531e01c into release/2.1.2 Nov 29, 2023
253 checks passed
@cmmarslender cmmarslender deleted the gw.dao_dedupe_parent_amts branch November 29, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants