Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add measured sizes for plot check #16830

Merged
merged 2 commits into from Jan 6, 2024
Merged

add measured sizes for plot check #16830

merged 2 commits into from Jan 6, 2024

Conversation

wjblanke
Copy link
Contributor

Purpose:

Avoid flagging plots for bad file sizes

Current Behavior:

Code uses estimates which are sometimes too low for large plots

New Behavior:

Use measures sizes if larger than estimate

Testing Notes:

Need to test with farm of varying plot k sizes. Should reduce the number of false positives but not flag additional plots

@wjblanke wjblanke added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Nov 14, 2023
@wjblanke wjblanke requested a review from a team as a code owner November 14, 2023 16:39
@neurosis69
Copy link
Contributor

Successfully tested this patch for my farm, all plots are being cached.

In the meantime I've also logged the prover size for a k39 plot, which is: 44367

@Starttoaster Starttoaster merged commit 101f1aa into main Jan 6, 2024
245 of 251 checks passed
@Starttoaster Starttoaster deleted the plotsizewjb branch January 6, 2024 00:13
mikehw pushed a commit to mikehw/chia-blockchain that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants